[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-15 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. I do not know how the AST import is relevant in this case, the 'implicit' function is not imported here. The test does something similar as the mentioned one, only the reported problem is after the imported function. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-15 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D64628#1584969 , @balazske wrote: > The mentioned commit has a test that reproduces the same problem, so this > revision is not needed (abandon it?). I think we should have this change, because it tests also if we can import

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-14 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. The mentioned commit has a test that reproduces the same problem, so this revision is not needed (abandon it?). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-14 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. The problem is already corrected in clang9 but maybe not in clang8. Something similar is fixed in https://reviews.llvm.org/rC357329. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628 ___

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-12 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Hmmm, did this result in an assertion? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

2019-07-12 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. New lines are added to test ctu-main.c to make code execute when a function with invalid source range is encountered on bug path with NoStoreFuncVisitor. Repository