This revision was automatically updated to reflect the committed changes.
Closed by commit rL366047: [clangd] Added highlighting for members and methods.
(authored by jvikstrom, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https
hokein accepted this revision.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:28
Variable = 0,
+ Field,
Function,
nit: put it `Field` around `Class`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
jvikstrom updated this revision to Diff 209509.
jvikstrom marked 6 inline comments as done.
jvikstrom added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64617/new/
https://reviews.llvm.org/D64617
Files:
clang-tool
jvikstrom updated this revision to Diff 209510.
jvikstrom added a comment.
Removed addToken for Exprs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64617/new/
https://reviews.llvm.org/D64617
Files:
clang-tools-extra/clangd/SemanticHighlighting.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:44
+ bool VisitMemberExpr(MemberExpr *ME) {
+if (const CXXMethodDecl *MD =
+dyn_cast(ME->getMemberDecl())) {
nit: this can be simplified like
```
if (co
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG from my side
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:28
Variable = 0,
+ MemberVariable,
Function,
nit: clang calls these
jvikstrom created this revision.
jvikstrom added reviewers: hokein, sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Added highlighting for members and methods.
Repository:
rG LLVM Github Monorepo
https://rev
