[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-15 Thread Bob Haarman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. inglorion marked an inline comment as done. Closed by commit rL366127: [clang] allow -fthinlto-index= without -x ir (authored by inglorion, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commit

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-15 Thread Bob Haarman via Phabricator via cfe-commits
inglorion updated this revision to Diff 209948. inglorion added a comment. Fix typo pointed out by MaskRay (thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64610/new/ https://reviews.llvm.org/D64610 Files: clang/include/clang/Basic/Diagno

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-12 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. LGTM with the comment fix from @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64610/new/ https://reviews.llvm.org/D64610 ___ cfe-com

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2123 + + // If running with -thinlto-index=, extensions that normally identify + // native object files actually identify LLVM bitcode files. `-fthinlto-index=` Repository:

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64610/new/ https://reviews.llvm.org/D64610 ___ cfe-c

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-11 Thread Bob Haarman via Phabricator via cfe-commits
inglorion added a comment. This was suggested on D64458 . If we take this change, D64458 can be simplified to just accepting -fthinlto-index= as a CoreOption without needing any further changes to Driver.cpp. I also changed the

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-11 Thread Bob Haarman via Phabricator via cfe-commits
inglorion created this revision. inglorion added reviewers: tejohnson, rnk, pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. Previously, passing -fthinlto-index= to clang required that bitcode files be explicitly marked by -x ir. This chan