[PATCH] D64592: [OpenMP] Fix declare target link implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367613: [OpenMP] Fix declare target link implementation (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210856. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cp

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added a comment. LG with a nit. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2595 +unsigned DeviceID, Line; +unsigned FileID = 0; +getTargetEntryUniqueInfo(CGM.getContext(), No need to initialize FileID. Repository: rC Clang

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210854. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cp

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/declare_target_link_codegen.cpp:22-23 +// HOST-DAG: @c_decl_tgt_ref_ptr = weak global i32* @c +// HOST-DAG: @_{{.*}}d = internal global i32 2 +// HOST-DAG: @_{{.*}}d_{{.*}}_decl_tgt

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2592-2593 llvm::raw_svector_ostream OS(PtrName); - OS << CGM.getMangledName(GlobalDecl(VD)) << "_decl_tgt_ref_ptr"; + unsigned DeviceID, Line; + unsigned FileID = 0; + OS << CGM.

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210673. gtbercea added a comment. - Add static variable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added a comment. I don't see a single test for static variables. Do we have at least one? If not, add it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 ___ cfe-comm

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210652. gtbercea added a comment. - Merge conditionals. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2594-2597 + if (!VD->isExternallyVisible()) +getTargetEntryUniqueInfo(CGM.getContext(), + VD->getCanonicalDecl()->getBeginLoc(), +

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210650. gtbercea added a comment. - Fix tests. Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target