Re: [PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Sorry about the breakage. I reverted it in r365922. On 7/12/19, 9:12 AM, "Brian Rzycki via Phabricator" wrote: brzycki added a comment. Hello @smeenai , this commit causes LLVM to fail to build when set set `-D BUILD_SHARED_LIBS=ON`. Here is the failing CMake and Ninja invocation

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

brzycki added a comment. Hello @smeenai , this commit causes LLVM to fail to build when set set `-D BUILD_SHARED_LIBS=ON`. Here is the failing CMake and Ninja invocation: /tools/build/cmake-3.14.5/bin/cmake \ -G Ninja \ -D CMAKE_MAKE_PROGRAM=/tools/build/ninja-1.9.0/ninja \

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581557 , @beanz wrote: > Yea, this makes sense even if it is a bit sad. We do use the > `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid > it here in part to free up the ability to link `li

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL365825: [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

beanz accepted this revision. beanz added a comment. Yea, this makes sense even if it is a bit sad. We do use the `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid it here in part to free up the ability to link `libclang_shared` before or in parallel to archiving the

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581194 , @smeenai wrote: > In D64579#1581172 , @phosek wrote: > > > While upgrading to newer CMake would be nice, I think it's unlikely that we > > could move all the way to 3.12

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581172 , @phosek wrote: > While upgrading to newer CMake would be nice, I think it's unlikely that we > could move all the way to 3.12 since that version was only released a year > ago and still isn't available in most

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most dis

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. @beanz, what do you think of this? I think it's kinda awful, but I can't think of a better alternative short of upgrading to CMake 3.12 (as detailed in my comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64579/new/

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Any static library with a PRIVATE dependency ends up with a $ generator expression in its INTERFACE_LINK_LIBRARIES, which won't be evaluate