This revision was automatically updated to reflect the committed changes.
Closed by commit rL365763: [clangd] Fix an assertion crash in
"ExtractVariable" tweak (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
hokein updated this revision to Diff 209172.
hokein marked an inline comment as done.
hokein added a comment.
Address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64556/new/
https://reviews.llvm.org/D64556
Files:
clang-tools-extra/clan
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Selection.cpp:361
return nullptr;
for (const Node *Ancestor = Root;; Ancestor = Ancestor->Children.front()) {
+asse
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:367
}
- return nullptr;
}
sorry, the previous patch rL365751 didn't fix the crash, and I re-read the code
more thoroughly, I think we w
hokein created this revision.
hokein added reviewers: sammccall, SureYeaah.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
GetTypePtr requires that the type should not be null, otherwise we hit
an assertion, we should use getTypePtrOrN
