vsk reopened this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Sorry about that, reopening per Eric's comment.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64540/new/
https://reviews.llvm.org/D64540
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365809: [CGDebugInfo] Simplify EmitFunctionDecl parameters,
NFC (authored by vedantk, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
echristo added a comment.
Not a huge fan of boolean parameters like this, perhaps factor out the context
as well into the caller and then we don't need it at all? Something else?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64540/new/
https://reviews.llvm.org/D64540
___
djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks @vsk!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64540/new/
https://reviews.llvm.org/D64540
___
cfe-commits mailing
vsk created this revision.
vsk added reviewers: djtodoro, aprantl.
Replace a `llvm::Function *` parameter with a bool, which seems harder
to set to the wrong value by accident.
https://reviews.llvm.org/D64540
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
Index:
