[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209304. quantum added a comment. Treat global.get of an immutable global as a memory access for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/incl

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked 5 inline comments as done. quantum added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > aheejin wrote:

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209274. quantum added a comment. Clean up table gen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209271. quantum marked 6 inline comments as done. quantum added a comment. Update comments regarding multable globals. Use `CHECK-DAG`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.l

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked 20 inline comments as done. quantum added a comment. I'll clean up the table gen stuff. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209258. quantum added a comment. Add error for non-local-exec TLS models. Fix unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/B

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

aheejin added a comment. Nice! Then where should we call `__wasm_init_tls`, in case within a library? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked an inline comment as done. quantum added a comment. In D64537#1579626 , @sunfish wrote: > This looks nice! > > > __wasm_init_tls(calloc(__builtin_wasm_tls_size(), 1)); > > Would it make sense to change the API contract for `__wasm_init_tls`

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209102. quantum added a comment. Fix linker warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

sunfish added a comment. This looks nice! > __wasm_init_tls(calloc(__builtin_wasm_tls_size(), 1)); Would it make sense to change the API contract for `__wasm_init_tls` to guarantee that initializes all bytes (with zeros as needed)? `__wasm_init_tls` knows what bytes it's initializing, so we co

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209090. quantum added a comment. Fix `fail` call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/lib

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209084. quantum added a comment. Add tests for `__builtin_wasm_tls_size`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWeb

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum planned changes to this revision. quantum added a comment. Need to add tests for the compiler intrinsic `__builtin_wasm_tls_size`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 _

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum created this revision. quantum added reviewers: tlively, aheejin, kripken, sbc100. Herald added subscribers: llvm-commits, cfe-commits, jfb, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. quantum planned changes to this revision. quantum added a comment.