[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL369749: [Docs][OpenCL] Several corrections to C++ for OpenCL (authored by stulova, committed by ). Changed prior to commit: https://reviews.llvm.org/D64418?vs=215922&id=216808#toc Repository: rL LLVM

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

svenvh accepted this revision. svenvh added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 215922. Anastasia added a comment. Added small corrections in various parts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst docs/UsersManual.rst Index: docs/UsersMa

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 215562. Anastasia marked an inline comment as done and 2 inline comments as not done. Anastasia added a comment. - Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: doc

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia added inline comments. Comment at: docs/UsersManual.rst:2771 + +There are only a few restrictions on allowed C++ features. For detailed information +please refer to documentation on Extensions (:doc:`LanguageExtensions`). svenvh wrote: > Anastasia wrot

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

svenvh added inline comments. Comment at: docs/LanguageExtensions.rst:1561 +s3.1.3). For OpenCL it means that implicit conversions are allowed from +named address space except for ``__constant`` to ``__generic`` address space +that is a superset of all others except for ``__const

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia marked 12 inline comments as done and 2 inline comments as done. Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:327 +.. _languageextensions-builtin-macros: + FYI, this is not part of my change. It was just hard to produce com

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 215106. Anastasia marked 26 inline comments as done. Anastasia added a comment. Addressed various comments from Kevin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia reopened this revision. Anastasia added a comment. This revision is now accepted and ready to land. Reopening to continue reviews. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 ___

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL366351: [Docs][OpenCL] Documentation of C++ for OpenCL mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. > Would it be ok if I fix those in a separate commit? I would really like to > commit the core part before the release branch is taken. I'm fine with this as long as we can continue the discussion

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia added a comment. In D64418#1589401 , @kpet wrote: > Very useful to have all of this documented! Thanks! Would it be ok if I fix those in a separate commit? I would really like to commit the core part before the release branch is taken. CHANG

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

kpet requested changes to this revision. kpet added a comment. This revision now requires changes to proceed. Very useful to have all of this documented! Thanks! Comment at: docs/LanguageExtensions.rst:1527 +This functionality is built on top of OpenCL C v2.0 and C++17. Regular

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Beside my two comments, I think this looks good. Comment at: docs/LanguageExtensions.rst:1614 + +By default references will refer to ``__generic`` address space objec

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 210101. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst docs/UsersManual.rst Index: docs/UsersManual.rst ==

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:1673 + +All builtin operators will be available in the specific address spaces, thus no conversion +to generic is performed. mantognini wrote: > "specific" seems to imply to the user will h

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 210064. Anastasia marked 5 inline comments as done. Anastasia added a comment. Addressed some review comments. Refs are still to be fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/Lang

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:1772 +``@_GLOBAL__sub_I_test.cl`` kernel to be enqueued. + + I think I should add something about dtors too. CHANGES SINCE LAST ACTION https:/

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

keryell added a comment. Good improvement! Comment at: docs/LanguageExtensions.rst:1758 +to enqueue constructor initialization kernel that has a name +``@_GLOBAL__sub_I_``. This kernel is only present if there +are any global objects to be initialized in the compiled binary. On

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini added a comment. Here are a few comments from me but keep in mind that English is not my primary language Comment at: docs/LanguageExtensions.rst:1562-1565 +C style cast will follow OpenCL C v2.0 rules (s6.5.5). All cast operators will +permit implicit conversion to

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

neil.hickey added inline comments. Comment at: docs/LanguageExtensions.rst:1538 +- ``dynamic_cast`` operator +- Only placement ``new``/``delete`` operators +- Standard C++ libraries. Currently there is no solution for alternative This seems weird, you say the fol

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, stuart, neil.hickey. Herald added subscribers: ebevhan, yaxunl. Added documentation of C++ for OpenCL mode into Clang User Manual and Language Extensions document. https://reviews.llvm.org/D64418 Files: docs/Lang