compnerd closed this revision.
compnerd added a comment.
SVN r365562
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64383/new/
https://reviews.llvm.org/D64383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added inline comments.
Comment at: src/CMakeLists.txt:440
+ endif()
+ if (LIBCXX_INSTALL_STATIC_LIBRARY)
+install(TARGETS cxx_static
Super nit: you don't have a newline here but do have a newline before the
LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY condi
smeenai accepted this revision.
smeenai added a comment.
Nice!
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64383/new/
https://reviews.llvm.org/D64383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
compnerd marked an inline comment as done.
compnerd added a comment.
@ldionne - that was exactly the motivation for this change - it always takes me
a couple of reads to figure out what we are trying to do here.
Comment at: src/CMakeLists.txt:441
+ if (LIBCXX_INSTALL_STATIC_L
ldionne added a comment.
I like that. Almost anything that helps us abolish global variables and lists
(here `LIBCXX_INSTALL_TARGETS`) in the CMake scripts is a good thing.
Comment at: src/CMakeLists.txt:441
+ if (LIBCXX_INSTALL_STATIC_LIBRARY)
+install(TARGETS cxx_static
compnerd created this revision.
compnerd added reviewers: smeenai, beanz, EricWF.
Herald added subscribers: libcxx-commits, ldionne, mgorny.
Rather than building up a list to iterate over later, just create multiple
`install` commands based on the configuration. This makes it easier to see
what
