[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL365411: clang-cl: Port cl.exe's C4659 to clang-cl (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. In D64349#1574742 , @rnk wrote: > lgtm Thanks! > May I ask what inspired this? :) I was looking through lld/COFF/Driver.cpp for something…ah, right, because D64156 touched it, and because I loo

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm May I ask what inspired this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 ___ cfe-commit

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. Thanks! Comment at: clang/test/Sema/pragma-section.c:57 + +// Not sure if this should warn or not. +__attribute__((section(".drectve"))) int drectve_int; rnk wrote: > I agree it probably shouldn't, I imagine mingw users will want to be a

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis updated this revision to Diff 208538. thakis marked 2 inline comments as done. thakis added a comment. Herald added a subscriber: mstorsjo. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.t

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2283 if (Attr *ClassAttr = getDLLAttr(Class)) { - if (auto *BaseTemplate = dyn_cast_or_null( - BaseType->getAsCXXRecordDecl())) { This file seems untouched except for wh

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis created this revision. thakis added a reviewer: rnk. https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaAttr.cpp clang/lib/Sema/SemaDeclAttr.cpp