This revision was automatically updated to reflect the committed changes.
Closed by commit rL365135: [clangd] Some tweaks on semantic highlighting
lookuptable. (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
hokein updated this revision to Diff 208020.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64202/new/
https://reviews.llvm.org/D64202
Files:
clang-tools-extra/cla
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:87
+// to the LSP client.
+std::vector> buildTextMateScopeLookupTable() {
+ std::vector> LookupTable;
hokein created this revision.
hokein added reviewers: sammccall, jvikstrom.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
- move toTextMateScope to SemanticHighlighting.h;
- move the buildLookupTable to LSP layer (as LSP requires such