[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini added a comment. I'll commit this along with D64083 in a few days in case John has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 _

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini updated this revision to Diff 207994. mantognini added a comment. Addressed missing colon in FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 Files: clang/include/clang/Basic/Buil

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/include/clang/Basic/Builtins.def:1516 // OpenCL v2.0 s6.13.9 - Address space qualifier functions. +// FIXME Pointer parameters of OpenC

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini marked an inline comment as done. mantognini added a comment. I added the FIXME and reduced the amount of testing. Let me know if it looks alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini updated this revision to Diff 207569. mantognini added a comment. Address comments: reduce testing & add FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 Files: clang/include/clang/Basic/

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

Anastasia added a comment. I would say in the interest of saving testing time running one of those test in C++ mode should be enough. Comment at: clang/lib/Sema/SemaExpr.cpp:5411 OverloadParams, EPI); - DeclContext *Parent = Co

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini created this revision. mantognini added reviewers: rjmccall, Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. This patch ensures built-in functions are rewritten using the proper parent declaration. Tests are added to ensure the functionality work