[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365124: [clangd] Turn background-index on by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:191 "Index project code in the background and persist index on disk. " "Experimental"), +llvm::cl::init(true)); --

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:191 "Index project code in the background and persist index on disk. " "Experimental"), +llvm::cl::init(true)); should we remove the `experimental` term h

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! please land once D64018 is done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64019/new/ https:/

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64019 Files: clang-tools-extra/clangd/tool/Cla