aheejin resigned from this revision.
aheejin added a comment.
Sorry, I don't think I know enough about this code to review this.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64015/new/
https://reviews.llvm.org/D64015
__
psalz updated this revision to Diff 207488.
psalz added a comment.
Move ownership of shared `MangleContext`s to `ASTContext`, return references
from `getSharedMangleContext`.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64015/new/
https://reviews.llvm.org/D6401
erichkeane added a comment.
I don't know of any problems that the shared mangle context would cause, though
I'm not sure about using the shared_ptr. It seems to me that SOMEONE should
own this, and the other should use a reference. IMO, the SharedMangleContexts
should be a unique_ptr and CGCXX
psalz created this revision.
psalz added reviewers: hliao, tra, aheejin.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
NOTE: This is a work in progress and mainly intended to highlight the issue -
i.e., I'm not certain the provided solution is appropriate.
Given this CUD
