[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

MaskRay added a comment. Herald added a subscriber: dexonsmith. I think we should not rely too much on the driver emitting object files. There can be many subtle differences (D68897 ). When the -emit-obj output is feed to llvm-nm, the clang cc1 command line sho

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added a comment. In D63978#1706764 , @JamesNagurne wrote: > In D63978#1706714 , @plotfi wrote: > > > In D63978#1706502 , @JamesNagurne > > wrote: > > > > > In D63978

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. In D63978#1706714 , @plotfi wrote: > In D63978#1706502 , @JamesNagurne > wrote: > > > In D63978#1706448 , @plotfi wrote: > > > > > In D63978#17

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added a comment. In D63978#1706502 , @JamesNagurne wrote: > In D63978#1706448 , @plotfi wrote: > > > In D63978#1706420 , @JamesNagurne > > wrote: > > > > > Our team

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. In D63978#1706448 , @plotfi wrote: > In D63978#1706420 , @JamesNagurne > wrote: > > > Our team maintains a downstream embedded ARM clang distribution and some > > tests from this comm

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added a comment. In D63978#1706420 , @JamesNagurne wrote: > Our team maintains a downstream embedded ARM clang distribution and some > tests from this commit have begun to fail for us. > For a number of th

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us. For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c,

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 3 inline comments as done. plotfi added a comment. In D63978#1701864 , @tamur wrote: > It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which > as far as I know, was only used for testing purposes until now. Is this > i

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

tamur added a comment. It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as far as I know, was only used for testing purposes until now. Is this intended? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL373538: [clang][ifs] Clang Interface Stubs ToolChain plumbing. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step.")

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/template-namespace-function.cpp:2 // REQUIRES: x86-registered-target -// RUN: %clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs \ -// RUN: -interface-stu

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221851. plotfi marked 6 inline comments as done. plotfi added a comment. addressing cindy and saleem's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files:

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); compnerd wrote: > Does

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); Does the interface me

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/include/clang/Driver/Options.td:635 + Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub Files, emit merged text not binary.">; def iterface_stub_version_EQ : JoinedOrSeparate<["-"], "interface-stub-version=">, Flags

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221469. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221467. plotfi added a comment. tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.t

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221453. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221252. plotfi added a comment. Adding back -c. Fixing driver for .ifs files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:15 + +void tools::ifstool::Merger::ConstructJob(Compilation &C, const JobAction &JA, + const InputInfo &Outpu

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221210. plotfi marked an inline comment as done. plotfi added a comment. fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driv

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 7 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added inline comments. Comment at: clang/include/clang/Driver/Phases.h:24 +Link, +IfsMerge }; Trailing comma please Comment at: clang/lib/Driver/Driver.cpp:3341 llvm::SmallVector FullPL; -types::getCompilationPhases

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3688 .Case("experimental-ifs-v1", "experimental-ifs-v1") - .Default(""); + .Default("experimental-ifs-v1"); nit: no need to check `ArgStr`

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 219226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 219211. plotfi marked 2 inline comments as done. plotfi added a reviewer: cishida. plotfi added a comment. Adding better wiring up to llvm-ifs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://rev

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added a comment. Tests? Comment at: clang/lib/Driver/Driver.cpp:3420 + // Add a link action if necessary. + if (!MergerInputs.empty()) { This isn't really a link action ... Comment at: clang/lib/Driver/Driver.cpp:3423 +Action

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 214924. plotfi edited the summary of this revision. plotfi added a comment. Herald added a subscriber: mgorny. Updated. Much better cleaner implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/