This revision was automatically updated to reflect the committed changes.
Closed by commit rGb9be5ce8f3e0: [Parser] Warn when ScopeDepthOrObjCQuals
overflows (authored by Mordante).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://re
Mordante added a comment.
Thanks for the review. I don't have SVN access, can you commit these changes?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://reviews.llvm.org/D63975
___
cfe-commits mailing list
cfe-commits@lists.
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://reviews.llvm.org/D63975
___
cfe-commits mailing list
Mordante updated this revision to Diff 209703.
Mordante added a comment.
Addresses @rjmccall's remarks.
Fixes the tests for the nested lambda's.
As suspected the blocks also have the same nesting limit, thus added a test for
them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
rjmccall added a comment.
(Blocks don't actually allow default arguments, but apparently we still parse
them, so we should test that path.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://reviews.llvm.org/D63975
___
cfe-co
rjmccall added a comment.
Thanks.
It's good to have a lambda test, but that one isn't actually testing the lambda
path — the place the diagnostic will trigger is just the normal
function-prototype path, just originally within a lambda. You can do something
like this:
template int foo(T &&
Mordante updated this revision to Diff 209513.
Mordante added a comment.
Moved the test out of the loop as suggested by rjmccall.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://reviews.llvm.org/D63975
Files:
clang/include/clang/AST/Decl.h
clang/include/clang/Basic
Mordante marked an inline comment as done.
Mordante added inline comments.
Comment at: clang/lib/Parse/ParseDecl.cpp:6587
+return;
+ }
+
rjmccall wrote:
> Mordante wrote:
> > rjmccall wrote:
> > > Comment indentation.
> > >
> > > Should we do this w
rjmccall added inline comments.
Comment at: clang/lib/Parse/ParseDecl.cpp:6587
+return;
+ }
+
Mordante wrote:
> rjmccall wrote:
> > Comment indentation.
> >
> > Should we do this when starting to parse a function prototype instead of
> > when parsi
Mordante updated this revision to Diff 209348.
Mordante added a comment.
tab -> space
adds an extra unit test for lambdas
fixes an off by one error found while testing the lambdas
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63975/new/
https://reviews.llvm.org/D63975
Files:
clang/in
Mordante marked an inline comment as done.
Mordante added inline comments.
Comment at: clang/lib/Parse/ParseDecl.cpp:6587
+return;
+ }
+
rjmccall wrote:
> Comment indentation.
>
> Should we do this when starting to parse a function prototype instead
rjmccall added inline comments.
Comment at: clang/lib/Parse/ParseDecl.cpp:6587
+return;
+ }
+
Comment indentation.
Should we do this when starting to parse a function prototype instead of when
parsing a parameter?
Repository:
rG LLVM Github Mon
Mordante created this revision.
Mordante added a reviewer: rsmith.
Mordante added a project: clang.
Herald added a subscriber: cfe-commits.
Before when the overflow occurred an assertion as triggered. Now check
whether the maximum has been reached and warn properly.
This patch fixes the original
13 matches
Mail list logo
