[PATCH] D63961: [clangd][xpc] pass the LSP value using data instead of string

2019-07-15 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. I'd add a test with non-empty non-LSP dictionary to specifically test that we're ignoring the content. I like const-correctness but that's up to you. Otherwise LGTM. Comment at: clang-tools-extra/clangd/unittests/xpc/ConversionTests.cpp:34 +TEST(JsonX

[PATCH] D63961: [clangd][xpc] pass the LSP value using data instead of string

2019-06-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 207164. arphaman added a comment. Added missing `xpc_release` in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63961/new/ https://reviews.llvm.org/D63961 Files: clang-tools-extra/clangd/unittests/xpc/ConversionTests.cpp clang-tools-e