This revision was automatically updated to reflect the committed changes.
Closed by commit rL364735: [clangd] Show better message when we rename macros.
(authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:204
+struct MacroSym {
+ llvm::StringRef Name;
sammccall wrote:
> sammccall wrote:
> > not sure about "sym" - it's an abbreviation and not very descriptive.
> > `MacroDefinition` i
hokein updated this revision to Diff 207244.
hokein marked 7 inline comments as done.
hokein added a comment.
Address review comments:
- renaming
- add unittest
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63922/new/
https://reviews.llvm.org/D639
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:661
+ Preprocessor &PP) {
+ // Also handle possible macro at the searched
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Previously, when we rename a macro, we get an error message of "there is
no symbol found".
This patch improves t
