[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365133: [CTU] Add support for virtual functions (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 _

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 208002. martong added a comment. - Remove ipa mode from the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.cpp

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-03 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D63920#1568269 , @martong wrote: > So, we would like to have a test which indicates that we can inline a virtual > function from another TU. These tests are at line 110 and 111. > > At line 113 we would like to have a test wh

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-03 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D63920#1568049 , @Szelethus wrote: > In D63920#1568031 , @martong wrote: > > > In D63920#1566035 , > > @baloghadamsoftware wrote: > > > > > Try t

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-03 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D63920#1568031 , @martong wrote: > In D63920#1566035 , > @baloghadamsoftware wrote: > > > Try to set analyzer option `IPAMode` to something different from its > > default value which

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-03 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 207738. martong added a comment. - Use -analyzer-config ipa=inlining in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-03 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D63920#1566035 , @baloghadamsoftware wrote: > Try to set analyzer option `IPAMode` to something different from its default > value which is `dynamic-bifurcate` in the test file. Ok I set it to `ipa=inlining` and then we rece

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-01 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. Try to set analyzer option `IPAMode` to something different from its default value which is `dynamic-bifurcate` in the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org

[PATCH] D63920: [CTU] Add support for virtual functions

2019-06-28 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/ctu-main.cpp:112 + // We cannot decide about the dynamic type. + clang_analyzer_eval(obj->fvcl(1) == 8); // expected-warning{{FALSE}} expected-warning{{TRUE}} + clang

[PATCH] D63920: [CTU] Add support for virtual functions

2019-06-28 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: Szelethus, xazax.hun. Herald added subscribers: cfe-commits, gamesh411, dkrupp, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.