This revision was automatically updated to reflect the committed changes.
Closed by commit rL364963: [clang-doc] Serialize child namespaces and records
(authored by juliehockett, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
DiegoAstiazaran updated this revision to Diff 207605.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63911/new/
https://reviews.llvm.org/D63911
Files:
clang-tools-extra/clang-doc/Mapper.cpp
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/clang-doc/Serialize.h
clang-too
DiegoAstiazaran updated this revision to Diff 207153.
DiegoAstiazaran marked 3 inline comments as done.
DiegoAstiazaran added a comment.
Change an if statement for a switch statement in `emitInfo(const RecordDecl *D,
...)`, it now handles correctly unexpected info types.
Fix spelling in comments.
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:366
+
+ if (I->Namespace[0].RefType == InfoType::IT_namespace) {
+auto Parent = llvm::make_unique();
Can you make this a switch statement, doing the appropriate things
DiegoAstiazaran updated this revision to Diff 207126.
DiegoAstiazaran marked 6 inline comments as done.
DiegoAstiazaran added a comment.
Herald added subscribers: kadircet, arphaman.
Add comments.
Extract repeated logic into mapDecl function in SerializeTest.cpp
Use EmptySID instead of specific US
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341
+ Parent->USR = ParentUSR;
+ Parent->ChildNamespaces.emplace_back(I->USR, I->Name,
InfoType::IT_namespace);
+ return {std::unique_ptr{std::move(I)},
juliehockett
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341
+ Parent->USR = ParentUSR;
+ Parent->ChildNamespaces.emplace_back(I->USR, I->Name,
InfoType::IT_namespace);
+ return {std::unique_ptr{std::move(I)},
You're probably
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri.
DiegoAstiazaran added a project: clang-tools-extra.
Serialization of child namespaces and records is now handled.
Namespaces can have child records and child namespaces.
Records can only
