jakehehrlich added a comment.
Can you upload `git diff -U10 ` functions so that I
can see the code without it being fragmented? It's hard to parse some of the
more fragmented stuff here
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:191-194
+static std::vector>
DiegoAstiazaran updated this revision to Diff 207148.
DiegoAstiazaran marked 6 inline comments as done.
DiegoAstiazaran added a comment.
Make DoctypeDecl a constexpr.
Early exit in TagNode::Render.
Functions of HTMLGenerator now return HTMLNodes instead of adding children to a
Node passed by refe
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:91
+struct HTMLFile {
+ llvm::SmallString<16> DoctypeDecl{""};
+ std::vector> Children; // List of child nodes
jakehehrlich wrote:
> Does this ever change? If not t
jakehehrlich added a comment.
Overall looks better. One of my comments causes a sweeping change to occur so
I'll respond back after thats done.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:91
+struct HTMLFile {
+ llvm::SmallString<16> DoctypeDecl{""};
+ std::vec
DiegoAstiazaran updated this revision to Diff 206920.
DiegoAstiazaran marked 7 inline comments as done.
DiegoAstiazaran added a comment.
Fix TagType enum name and members.
Add anonymous namespace.
Separate the implementation from the definition for some functions.
Use emplace_back instead of push_
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21
+class HTMLTag {
+public:
Put the class definitions in an anonymous namespace
(https://llvm.org/docs/CodingStandards.html#anonymous-namespaces)
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri.
DiegoAstiazaran added a project: clang-tools-extra.
Nodes are used to represent each part of the HTML file. There are TagNodes that
represent every HTML tag (p, h1, div, ...) and they h
