[PATCH] D63857: [clang-doc] Add a structured HTML generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL365687: [clang-doc] Add a structured HTML generator (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208792. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857 Files: clang-tools-extra/clang-doc/CMakeLists.txt clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Generators.h cla

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208739. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Remove empty line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857 Files: clang-tools-extra/clang-doc/CMak

[PATCH] D63857: [clang-doc] Add a structured HTML generator

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM, unless Jake has further comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:503 + } + // std::move(Nodes.begin(), Nodes.end(), std::back_

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:75 +Children.emplace_back( +llvm::make_unique(Text.str(), !InlineChildren)); + } jakehehrlich wrote: > I think you can just write `Children.emplace_back(

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208527. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. Add helper function to move a vector's elements to another vector. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added a comment. As in I'm not quite ready for this to land but It looks preety solid. I think if you respond to those comments I'll take one last look and then give an actual accept CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added a comment. This looks good to me! Comment at: clang-tools-extra/clang-doc/Generators.cpp:75-77 extern volatile int YAMLGeneratorAnchorSource; extern volatile int MDGeneratorAnchorSource; +extern volatile int HTMLGeneratorAnchorSource; I don

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207174. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add a variable to use as a reference to the last item in a vector instead of doing vector.back(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:228 + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H2, "Functions")); + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_DIV)); + for (const auto &F : Functions) {

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207160. DiegoAstiazaran retitled this revision from "[clang-doc] Structured HTML generator" to "[clang-doc] Add a structured HTML generator". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added subscribers