ymandel added inline comments.
Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h:48
+
+template
class TestClangTidyAction : public ASTFrontendAction {
gribozavr wrote:
> "CheckTypes"? 'cause "Checks" below is also technically a "check list".
A
ymandel updated this revision to Diff 206667.
ymandel marked 3 inline comments as done.
ymandel added a comment.
responded to comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63784/new/
https://reviews.llvm.org/D63784
Files:
clang-tools-e
gribozavr accepted this revision.
gribozavr added a comment.
Good catch!
Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h:48
+
+template
class TestClangTidyAction : public ASTFrontendAction {
"CheckTypes"? 'cause "Checks" below is also tech
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63784/new/
https://reviews.llvm.org/D63784
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.
Currently, `clang::tidy::test::runCheckOnCode()` constructs the check
instances *before* initializing the ClangTidyContext. This ordering causes
problems when th
