This revision was automatically updated to reflect the committed changes.
Closed by commit rL364280: [clangd] Cleanup the duplicated getTokenRange.
(authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
hokein updated this revision to Diff 206380.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63714/new/
https://reviews.llvm.org/D63714
Files:
clang-tools-ex
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/XRefs.cpp:926
for (const auto &Ref : MainFileRefs) {
Location Result;
+if (auto Range =
nit: move de
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Also lift it to SourceCode.h, so that it can be used in other places
(semantic code highlighting).
Repository:
rG LLVM Github Mon
