juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21
namespace {
Eugene.Zelenko wrote:
> Anonymous namespace is used for functions when LLVM Coding Guidelines tells
> using static for same purpose.
Actually, since
DiegoAstiazaran updated this revision to Diff 206317.
DiegoAstiazaran edited the summary of this revision.
DiegoAstiazaran added a comment.
Herald added a subscriber: ormris.
Path name generation was moved to serialization phase as @juliehockett
suggested.
Empty string declaration fixed.
Removed
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21
namespace {
Anonymous namespace is used for functions when LLVM Coding Guidelines tells
using static for same purpose.
Comment at: clang-to
juliehockett added a comment.
General design thought: could we move the path name construction to
`Serialize.cpp`? Essentially, move the logic that builds the path name from the
namespaces and name to the serialize step (you'll have to add the
`OutDirectory` to the `ClangDocContext` so that you
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri.
DiegoAstiazaran added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
tags are added for the parents of records.
The link redirects to the parent's info file
