This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0407f549653: [PowerPC][Altivec] Fix offsets for vec_xl and
vec_xst (authored by nemanjai).
Herald added subscribers: shchenz, wuzish.
Changed prior to commit:
https://reviews.llvm.org/D63636?vs=206123&
jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63636/new/
https://reviews.llvm.org/D63636
__
nemanjai updated this revision to Diff 206123.
nemanjai added a comment.
Remove the double cast. Simplify the test case. Rename the temp.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63636/new/
https://reviews.llvm.org/D63636
Files:
lib/Headers/altivec.h
te
nemanjai marked 3 inline comments as done.
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:16364
signed short *__ptr) {
- return *(unaligned_vec_sshort *)(__ptr + __offset);
+ signed char *Adjusted = (sign
jsji added a comment.
A few questions.
Comment at: lib/Headers/altivec.h:16364
signed short *__ptr) {
- return *(unaligned_vec_sshort *)(__ptr + __offset);
+ signed char *Adjusted = (signed char *)__ptr + __offset;
+ ret
nemanjai created this revision.
nemanjai added reviewers: hfinkel, jsji, rzurob, saghir.
Herald added a subscriber: kbarton.
Herald added a project: clang.
As we currently have it implemented in altivec.h, the offsets for these two
intrinsics are element offsets. The documentation in the ABI (as
