[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan abandoned this revision. TomTan added a comment. The fix in LLVM was merged as https://reviews.llvm.org/rL364115. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63617/new/ https://reviews.llvm.org/D63617 ___ cf

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552615 , @rnk wrote: > Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel > to select different instructions for different OSs, and I'd prefer to > implement it that way. Ok, did the implement

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel to select different instructions for different OSs, and I'd prefer to implement it that way. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63617/new/ https://review

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552561 , @rnk wrote: > I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on > aarch64-windows-*, so other frontends (Rust etc) get the right behavior by > default. Right now, AArch64 doesn't do

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on aarch64-windows-*, so other frontends (Rust etc) get the right behavior by default. Right now, AArch64 doesn't do anything special for DEBUGTRAP, so we get the default behavior of `llvm.trap`. Is

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan created this revision. TomTan added reviewers: efriedma, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. On Windows ARM64, intrinsic `__debugbreak` should be compiled into `brk #0xF000` which is different from llvm intrinsic `debugtrap