[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29802/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 ___ cfe-commits mail

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expec

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL364752: [ASTImporter] Propagate error from ImportDeclContext (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, The patch looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 __

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. @a_sidorin Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong updated this revision to Diff 206250. martong marked 2 inline comments as done. martong added a comment. - Use make_scope_exit - Add test ErrorIsNotPropagatedFromMemberToNamespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ htt

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); jkorous wrote: > You might consider using just a lambda with `llvm::make_scope_exit`. > > ht

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong updated this revision to Diff 206223. martong added a comment. - Remove the macro and use std::string.op+ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 Files: clang/lib/AST/ASTImporter.cpp cla

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4743 +} + INSTANTIATE_TEST_CASE_P(ParameterizedTests, ErrorHandlingTest, Maybe add a similar test for namespace and check that the error is not propagated? Repository: rG LL

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong updated this revision to Diff 206018. martong added a comment. - Remove formatv b/c it can't handle braces in code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 Files: clang/lib/AST/ASTImporter.

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

jkorous added a comment. I don't have the insight to LGTM the whole change - just a nit about implementation detail. Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); You might consider using just a lambda with `l

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong added a parent revision: D62373: [ASTImporte