aheejin added a comment.
`CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with
`LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report:
https://bugs.llvm.org/show_bug.cgi?id=42575
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63503/new/
https://reviews.llvm.org/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365092: cmake: Add CLANG_LINK_CLANG_DYLIB option (authored
by tstellar, committed by ).
Herald added a project: LLVM.
Cha
beanz added a comment.
One comment inline. Otherwise LGTM.
Comment at: clang/CMakeLists.txt:327
+set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL
+"Link tools against libclang_shared.so")
+
We should generate a config error if `LLVM_LINK_LLVM_D
tstellar added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63503/new/
https://reviews.llvm.org/D63503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
tstellar created this revision.
tstellar added reviewers: mgorny, beanz, smeenai, phosek, sylvestre.ledru.
Herald added subscribers: cfe-commits, arphaman.
Herald added a project: clang.
Setting CLANG_LINK_CLANG_DYLIB=ON causes clang tools to link against
libclang_shared.so instead of the individu
