[PATCH] D63497: Add support for openSUSE RISC-V triple

MaskRay added a comment. I created D109727 to clean up the `*Triples` variables. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497 ___ cfe-commi

[PATCH] D63497: Add support for openSUSE RISC-V triple

MaskRay added a comment. Herald added subscribers: vkmr, frasercrmck, luismarques, sameer.abuasal, Jim. hexchain pointed me to this patch and asked why Suse can add a triple here... So here are some explanations: We should avoid adding more target triples to `CollectLibDirsAndTriples`. Every ris

[PATCH] D63497: Add support for openSUSE RISC-V triple

lenary added a comment. Thanks @schwab, sorry we took so long to merge your patch, but it's merged now! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497 ___ cfe-commits mailing

[PATCH] D63497: Add support for openSUSE RISC-V triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL367565: Add support for openSUSE RISC-V triple (authored by lenary, committed by ). Herald added a subscriber: s.egerton. Changed prior to commit: https://reviews.llvm.org/D63497?vs=206423&id=212814#toc

[PATCH] D63497: Add support for openSUSE RISC-V triple

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: lenary. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497

[PATCH] D63497: Add support for openSUSE RISC-V triple

schwab updated this revision to Diff 206423. schwab added a comment. Herald added subscribers: jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Test added Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D63497: Add support for openSUSE RISC-V triple

schwab updated this revision to Diff 206173. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497 Files: clang/lib/Driver/ToolChains/Gnu.cpp llvm/unittests/ADT/TripleTest.cpp Index: llvm/unittests/ADT/TripleTest.cpp ==

[PATCH] D63497: Add support for openSUSE RISC-V triple

asb added a comment. Thanks for the contribution! I'd recommend adding a skeleton toolchain dir structure to clang/test/Driver/Inputs and adding a test to clang/test/Driver/riscv64-toolchain.c. You should be able to see examples in test/Driver/Inputs. Repository: rC Clang CHANGES SINCE LAS

[PATCH] D63497: Add support for openSUSE RISC-V triple

lebedev.ri added a reviewer: asb. lebedev.ri added a comment. Nice :) It is also a good idea to upload patches with full context (`-U9`) Comment at: llvm/unittests/ADT/TripleTest.cpp:333 + T = Triple("riscv64-suse-linux"); + EXPECT_EQ(Triple::riscv64, T.getArch());

[PATCH] D63497: Add support for openSUSE RISC-V triple

schwab created this revision. Herald added subscribers: llvm-commits, cfe-commits, rkruppe, dexonsmith, rogfer01, shiva0217, kito-cheng. Herald added projects: clang, LLVM. Repository: rC Clang https://reviews.llvm.org/D63497 Files: clang/lib/Driver/ToolChains/Gnu.cpp llvm/unittests/ADT/T