thakis resigned from this revision.
thakis added a comment.
hans and compnerd got this, no need for so many reviewers :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63473/new/
https://reviews.llvm.org/D63473
___
cfe-commits mailing list
cfe
hans added a comment.
> The System V i386 bug fix (https://reviews.llvm.org/D59744) makes it
> impossible
Please refer to the svn revision instead of the code review.
> for 32-bit Linux Chromium to write an assembly function that works with both
> trunk clang and clang 8.0.0, which makes it di
RKSimon added inline comments.
Comment at: test/CodeGen/x86_32-m64.c:6
// RUN: %clang_cc1 -w -O2 -fblocks -triple i386-pc-win32 -emit-llvm -o - %s |
FileCheck %s --check-prefixes=CHECK,WIN32
+// RUN: %clang_cc1 -w -O2 -fblocks -triple i386-pc-linux-gnu -target-cpu
pentium4 -em
wxiao3 updated this revision to Diff 205261.
wxiao3 added a reviewer: compnerd.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63473/new/
https://reviews.llvm.org/D63473
Files:
docs/ReleaseNotes.rst
include/clang/Basic/LangOptions.h
lib/CodeGen/TargetInfo.cpp
lib/Frontend/Compiler
wxiao3 marked an inline comment as done.
wxiao3 added a comment.
Yes, there is a test to ensure that Darwin defaults to the old behaviour in
"test/CodeGen/x86_32-m64.c".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63473/new/
https://reviews.llvm.org/D63473
compnerd added a comment.
Could you please add a test to ensure that Darwin defaults to the old behaviour?
Comment at: include/clang/Basic/LangOptions.h:142
+/// Attempt to be ABI-compatible with code generated by Clang 8.0.x
+/// (https://reviews.llvm.org/D59744). This
wxiao3 created this revision.
wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, craig.topper,
hjl.tools, rnk, andreadb, gbedwell, rjmccall, krytarowski, mgorny, joerg,
RKSimon, hans, thakis.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The System V i386 bug fix
