[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso updated this revision to Diff 206357. Charusso added a comment. - A working one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 Files: clang/include/clang/Basic/JsonSupport.h clang/test/Analysis/dump_egraph.c clang/test/Analysis/

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

This revision was automatically updated to reflect the committed changes. Closed by commit rL364270: [analyzer] JsonSupport: Escape escapes (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso updated this revision to Diff 206356. Charusso added a comment. - More test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 Files: clang/include/clang/Basic/JsonSupport.h clang/test/Analysis/dump_egraph.c clang/test/Analysis/expl

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1556831 , @NoQ wrote: > See also https://xkcd.com/1638/ Well, after a month of escaping we are still have problems, so it is truly comes to your brain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. See also https://xkcd.com/1638/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! I guess it makes sense to add a test into `test/Analysis/exploded-graph-rewriter/escapes.c` as well, so that to learn if we can actually parse it later. CHANGES SINCE LAST ACTION https://r

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso updated this revision to Diff 206248. Charusso added a comment. - Test case added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 Files: clang/include/clang/Basic/JsonSupport.h clang/test/Analysis/dump_egraph.c Index: clang/test/

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. I guess let's add a test for the unicode problem that you're seeing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 ___ cfe-commits mailing list cfe-comm

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. My problem is demonstrated (and solved) by D63519 . If i revert my changes but apply this patch instead, my test keeps failing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.o

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1549225 , @NoQ wrote: > I mean, i'm removing backslashes but you're adding more backslashes. > Therefore i think we're talking about different issues. You *have to* remove backslashes, because sometimes we have ``

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. I mean, i'm removing backslashes but you're adding more backslashes. Therefore i think we're talking about different issues. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1549144 , @NoQ wrote: > Hmm, this doesn't seem to solve my problem in D62761 > . Let me write some actual test case so that > you knew it's fixed when it's fixed. Well, I have did the

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. Hmm, this doesn't seem to solve my problem in D62761 . Let me write some actual test case so that you knew it's fixed when it's fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D63462 Fi