This revision was automatically updated to reflect the committed changes.
Closed by commit rL364011: [clang] Small improvments after Adding APValue to
ConstantExpr (authored by Tyker, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Tyker updated this revision to Diff 205944.
Tyker marked an inline comment as done.
Tyker added a comment.
made the requested changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63376/new/
https://reviews.llvm.org/D63376
Files:
clang/include/clang/AST/ASTContext.h
clang/include/
Tyker added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:10298
+ bool AllowFold = true,
+ bool StoreResult = true);
ExprResult VerifyIntegerConstantExpression(Expr *E, llvm:
rsmith added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:10298
+ bool AllowFold = true,
+ bool StoreResult = true);
ExprResult VerifyIntegerConstantExpression(Expr *E, llvm
Tyker marked an inline comment as done.
Tyker added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:10298
+ bool AllowFold = true,
+ bool StoreResult = true);
ExprResult Verify
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Nice cleanup!
Comment at: clang/include/clang/Sema/Sema.h:10298
+ bool AllowFold = true,
+
Tyker updated this revision to Diff 204992.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63376/new/
https://reviews.llvm.org/D63376
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Expr.h
clang/include/clang/AST/Stmt.h
clang/include/clang/Sema/Sema.h
clang/l
Tyker updated this revision to Diff 204916.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63376/new/
https://reviews.llvm.org/D63376
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Expr.h
clang/include/clang/AST/Stmt.h
clang/include/clang/Sema/Sema.h
clang/l
Tyker created this revision.
Tyker added a reviewer: rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
this patch has multiple small improvements related to the APValue in
ConstantExpr.
changes:
- APValue in ConstantExpr are now cleaned up using ASTContext::addDestr
