[PATCH] D63330: [clangd] Add Value field to HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL364390: [clangd] Add Value field to HoverInfo (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:920 + {R"cpp( +constexpr int add(int a, int b) { return a + b; } +int [[b^ar]] = add(1, 2); sammccall wrote: > constexpr may not be required here, I

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet updated this revision to Diff 206210. kadircet marked 9 inline comments as done and an inline comment as not done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63330/new/ https://reviews.llvm.o

[PATCH] D63330: [clangd] Add Value field to HoverInfo

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Implementation LG though please do check that the new test results look useful and not too duplicative Comment at: clang-tools-extra/clangd/XRefs.cpp:723 + // Fill in

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:733 +else + Init->printPretty(ValueOS, nullptr, Policy); + } sammccall wrote: > why not print the non-evaluated init if it's dependent? not-necessary anymore, sin

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet updated this revision to Diff 205530. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63330/new/ https://reviews.llvm.org/D63330 Files: clang-tools-ex

[PATCH] D63330: [clangd] Add Value field to HoverInfo

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:722 + // Fill in value with initializer. Puts evaluated version if possible. + if (const auto *Var = dyn_cast(D)) { do we want the initializer both here and in Definition? I susp

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Put a symbols value information which is deduced from initializer expression into HoverInfo struct. Repository: