[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 abandoned this revision. xbolva00 added a comment. Right :( Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63299/new/ https://reviews.llvm.org/D63299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

aaron.ballman added a comment. In D63299#1548306 , @xbolva00 wrote: > Ok, If we peek a few tokens ahead and check attribute if it is stmt attribute > and then we call MaybeParseGNUAttr - this probably would work but are you > fine with it as a workaround

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 reclaimed this revision. xbolva00 added a comment. Ok, If we peek a few tokens ahead and check attribute if it is stmt attribute and then we call MaybeParseGNUAttr - this probably would work but are you fine with it as a workaround ? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

aaron.ballman added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true); xbolva00 wrote: > xbolv

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true); --

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 marked an inline comment as done. xbolva00 added a comment. isDeclarationStatement() returns true for __attribute__((fallthough)) ; Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParse

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 added a comment. As we see. this is not good place to parse __attribute__((fallthough), which blocks D63260 . Maybe @aaron.ballman could help us since he knows this code better.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith, efriedma, nickdesaulniers. Herald added a project: clang. Herald added a subscriber: cfe-commits. Please https://reviews.llvm.org/D63260 Repository: rC Clang https://reviews.llvm.org/D63299 Files: lib/Parse/Pa