This revision was automatically updated to reflect the committed changes.
Closed by commit rL363840: Unify DependencyFileGenerator class and
DependencyCollector interface (NFCI) (authored by arphaman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed p
aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63290/new/
https://reviews.llvm.org/D63290
___
cfe-commits mailing list
cfe-commits@
arphaman updated this revision to Diff 205438.
arphaman marked 3 inline comments as done.
arphaman added a comment.
Address review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63290/new/
https://reviews.llvm.org/D63290
Files:
clang/include/clang/Frontend/CompilerInstance.h
aganea added a reviewer: benlangmuir.
aganea added inline comments.
Comment at: clang/include/clang/Frontend/Utils.h:118
/// Builds a depdenency file when attached to a Preprocessor (for includes) and
/// ASTReader (for module imports), and writes it out at the end of process
arphaman updated this revision to Diff 204611.
arphaman added a comment.
Fix the missing word in the comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63290/new/
https://reviews.llvm.org/D63290
Files:
clang/include/clang/Frontend/CompilerInstance.h
clang/include/clang/Frontend
arphaman created this revision.
arphaman added reviewers: Bigcheese, vsapsai, bruno, aganea.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: clang.
This NFCI patch makes DependencyFileGenerator a DependencyCollector as it was
intended when DependencyCollector was introduced
