This revision was automatically updated to reflect the committed changes.
Closed by commit rL364266: [analyzer] Add more timers for performance
profiling. (authored by dergachev, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228
-ExprEngine::~ExprEngine() {
- BR.FlushReports();
NoQ wrote:
> xazax.hun wrote:
> > Hmm. Maybe add an assert that all the bug reports are flushed at this
> > point?
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228
-ExprEngine::~ExprEngine() {
- BR.FlushReports();
xazax.hun wrote:
> Hmm. Maybe add an assert that all the bug reports are flushed at
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228
-ExprEngine::~ExprEngine() {
- BR.FlushReports();
Hmm. Maybe add an assert that all the bug reports are flushed at this point?
Just to make sure we never need this :
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good :) More diagnostics are always welcome.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63227/new/
https://reviews.llvm.org/D63227
__
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus,
baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, szepet.
Herald added a project: clang.
`-analyzer-stats` now allows you to fi
