[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao abandoned this revision. hliao added a comment. revised change is already committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits maili

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. ping again. not sure my explanation gives more details on why this patch is created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. In D63164#1542361 , @rsmith wrote: > I think this is the wrong way to handle this issue. We need to give lambdas a > mangling if they occur in functions for which there can be definitions in > multiple translation units. In regular

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

rsmith added a comment. I think this is the wrong way to handle this issue. We need to give lambdas a mangling if they occur in functions for which there can be definitions in multiple translation units. In regular C++ code, that's inline functions and function template specializations, so that

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. ping for comment as one of HIP-based workload is blocked by this issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits ma

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. In D63164#1538968 , @tra wrote: > So, in short, what you're saying is that lambda type may leak into the > mangled name of a `__global__` function and ne need to ensure that the > mangled name is identical for both host and device,

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

tra added a comment. So, in short, what you're saying is that lambda type may leak into the mangled name of a `__global__` function and ne need to ensure that the mangled name is identical for both host and device, hence the need for consistent naming of lambdas. If that's the case, shouldn't

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Clang follows its own scheme for lambdas which don't need to follow ODR rule. That scheme will assign an unqiue ID within the TU scope and won't be unique or