MyDeveloperDay added a comment.
mark sure you mark off the comments as you consider them done.
Comment at: lib/Format/FormatToken.h:519
+/// Returns whether the token is a Bit field, and checks whether
+/// the Style is C / C++.
this looks like it needs a cla
Manikishan updated this revision to Diff 204040.
Manikishan marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D63062
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndent
Manikishan updated this revision to Diff 204022.
Manikishan marked 4 inline comments as done.
Manikishan added a comment.
Changed Style name to OnePerLineBitFieldDecl
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D63062
Files:
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added inline comments.
This revision now requires changes to proceed.
Comment at: docs/ClangFormatStyleOptions.rst:194
+**BitFieldDeclsOnSeparateLines** (``bool``)
+ If ``true``, Align Bitfield Declarations on s
Manikishan updated this revision to Diff 203860.
Manikishan marked 4 inline comments as done.
Manikishan added a comment.
Updated unittest
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D63062
Files:
docs/ClangFormatStyleOpti
Manikishan updated this revision to Diff 203841.
Manikishan added a comment.
Made some missing style modifications in the last revision
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D63062
Files:
docs/ClangFormatStyleOptions
Manikishan updated this revision to Diff 203838.
Manikishan marked 4 inline comments as done.
Manikishan added a comment.
Added unittests and made the changes suggested by @mgorny
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D
mgorny requested changes to this revision.
mgorny added inline comments.
This revision now requires changes to proceed.
Comment at: docs/ClangFormatStyleOptions.rst:195
+**BitFieldDeclsOnSeparateLines** (``bool``)
+ If ``true``, Align Bitfield Declarations on seperate lines.
+
-
Manikishan updated this revision to Diff 203833.
Manikishan added a subscriber: mgorny.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63062/new/
https://reviews.llvm.org/D63062
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.
You need to add a unit test in clang/unittests
Comment at: docs/ClangFormatStyleOptions.rst:195
+**BitFieldDeclsOnSeparateLines** (``bool``)
+ If `
10 matches
Mail list logo