[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363803: [clangd] Collect tokens of main files when building the AST (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In D62956#1547826 , @sammccall wrote: > Can we add a test using TestTU that does a very basic verification of > expanded/spelled tokens (first after preamble, last token in file)? Done. Will land this tomorrow, want to run

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 205387. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rename tokens() to getTokens() for consistency with the rest of ParsedAST. - Update comments. - Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can we add a test using TestTU that does a very basic verification of expanded/spelled tokens (first after preamble, last token in file)? Comment at: clang-tools-extra

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. ilya-biryukov added a child revision: D61681: [clangd] A code tweak to expand a macro. The first use of this is a