[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast updated this revision to Diff 205590. hubert.reinterpretcast added a comment. Update based on review comments from D62949 as confirmed in D62952 Normalized versions of the reference expected SARIF output f

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1548620 , @hubert.reinterpretcast wrote: > In D62952#1548593 , @aaron.ballman > wrote: > > > But is there a reason to not keep `%diff_sarif` and define it in terms of > >

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548593 , @aaron.ballman wrote: > But is there a reason to not keep `%diff_sarif` and define it in terms of > `%normalize_sarif | diff -U1 -b` within lit.local.cfg? I guess I don't see > the benefit to e

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1548580 , @hubert.reinterpretcast wrote: > In D62952#1548377 , @aaron.ballman > wrote: > > > In general, that seems reasonable, but I would prefer to take care of more > >

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548377 , @aaron.ballman wrote: > In general, that seems reasonable, but I would prefer to take care of more of > the work in lit.local.cfg than have to deal with that atrocious RUN line in > every test

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

aaron.ballman added a comment. In D62952#1535088 , @hubert.reinterpretcast wrote: > @aaron.ballman, for similar cases in the plist output, it has been proposed > > - that the reference expected file be committed into the tree pre-normalized, > and > - th

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. @aaron.ballman, for similar cases in the plist output, it has been proposed - that the reference expected file be committed into the tree pre-normalized, and - that tool be modified such that the output file has a newline at the end of the file. Does tha

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

Szelethus added a reviewer: aaron.ballman. Szelethus added a comment. Added Aaron as he wrote the this diagnostic output type :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 __

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla