[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

This revision was automatically updated to reflect the committed changes. Closed by commit rL362994: [analyzer][tests] Add normalize_plist to replace diff_plist (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. @NoQ, I've updated the patches based on the changes you suggested. This patch, D62950 , and D62951 now looks much cleaner. These are now dependent on the approval of D63041

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast updated this revision to Diff 203706. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. I've tested the pre-normalization and it looks like I can commit it tomorrow. I noticed that the following three files appear to be unreferenced: clang/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist clang/test/Analysis/Inputs/expected-plist

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533605 , @NoQ wrote: > Ok! I'll be happy to have this addressed incrementally. I think it should be safe to at least commit the pre-normalization directly first. I'll take a look, and update the patch i

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok! I'll be happy to have this addressed incrementally. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62949/new/ https://reviews.llvm.org/D62949 _

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533574 , @NoQ wrote: > I think we should: > > - Pre-normalize our expected outputs so that we didn't have to normalize them > in every run-line. Okay; I think this might be possible to do in a separate

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

NoQ added a comment. Thanks! I think we should: - Pre-normalize our expected outputs so that we didn't have to normalize them in every run-line. - Treat the lack of newline in plist output as a bug and try to fix it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla