[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL363612: Clang :: Sema/wchar.c has long been failing on Solaris: (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 ___ cfe-commit

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro added a comment. In D62944#1542217 , @efriedma wrote: > For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && > !defined(__LP64__)`, but I don't think the alternative is better. We could > restrict the test so it doesn't run us

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro updated this revision to Diff 205012. ro added a comment. Herald added a subscriber: krytarowski. Adapt `Sema/format-strings.c`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 Files: lib/Basic/Targets/OSTargets.h

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

efriedma added a comment. For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && !defined(__LP64__)`, but I don't think the alternative is better. We could restrict the test so it doesn't run using a Solaris target triple, but we actually want coverage here: the differenc

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro added a comment. Ping? This has been a week, too. According to gcc/config headers, there are quite a number of targets with long int for wchar_t/wint_t, so there should be some generic way to handle the Clang :: Sema/format-strings.c failure. Suggestions? Repository: rC Clang CHANGES

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro created this revision. ro added reviewers: rsmith, fedor.sergeev. Herald added a subscriber: jyknight. Herald added a project: clang. `Clang :: Sema/wchar.c` has long been failing on Solaris: error: 'error' diagnostics expected but not seen: File /vol/llvm/src/clang/local/test/Sema/wcha