sunfish marked an inline comment as done.
sunfish added inline comments.
Comment at: clang/test/Driver/wasm-toolchain.c:116
+// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]"
+// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"
"{{.*[/\\]}}libclang_rt.bui
bjope added inline comments.
Comment at: clang/test/Driver/wasm-toolchain.c:116
+// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]"
+// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"
"{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out"
+
-
sunfish marked an inline comment as done.
sunfish added inline comments.
Comment at: clang/test/Driver/wasm-toolchain.c:116
+// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]"
+// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"
"{{.*[/\\]}}libclang_rt.bui
bjope added inline comments.
Comment at: clang/test/Driver/wasm-toolchain.c:116
+// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]"
+// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"
"{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out"
+
-
bjope added inline comments.
Comment at: clang/test/Driver/wasm-toolchain.c:116
+// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]"
+// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"
"{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out"
+
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd496437a0bfd: [WebAssembly] Add support for
-mexec-model=reactor (authored by sunfishcode).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62922/new/
https:/
sunfish added a comment.
This addresses the review feedback from earlier. To answer this question:
> I assume that all he users -Wl args come after.. so its still possible to set
> --entry on the command line?
Yes, that is what happens.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
sunfish updated this revision to Diff 257171.
sunfish added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Rebase, update, add a test, and add basic error reporting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62
