[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-05 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362667: [WebAssembly] Support Leak Sanitizer on Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum added a comment. It's not urgent, so I am willing to wait a day or two for commit access. If I still can't get access by then, I'll ask someone else to commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.l

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. I see. Do you want me to commit this, or you are gonna get a commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-com

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum added a comment. LSan is supposed to be linked in to replace some C library functions, and does not change the generated LLVM IR code, so there is nothing to actually test in LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-03 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Oh, can we have a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-03 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. LSan is currently being ported to Emscripten and mostly works. Enabling the support in upstream would simpli