[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362380: [ARM] Fix recent breakage of -mfpu=none. (authored by statham, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62729?vs=202681&id=202688#t

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks for adding the new test. I agree with keeping both tests ( I wasn't very clear). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham updated this revision to Diff 202681. simon_tatham added a comment. Added the extra checks in `arm-mfpu.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62729/new/ https://reviews.llvm.org/D62729 Files: clang/lib/Driver/ToolChains/

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + d

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + simon_tatham wrote: > dmgreen wrote: > > lebedev.ri w

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + d

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + lebedev.ri wrote: > Generally clang codegen tests sho

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + Generally clang codegen tests should test `-emit-l

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham created this revision. simon_tatham added reviewers: SjoerdMeijer, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. The recent change D60691 introduced a bug in