[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

2020-03-31 Thread Bill Wendling via Phabricator via cfe-commits
void edited subscribers, added: manojgupta; removed: cfe-commits. void added a comment. Friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62627/new/ https://reviews.llvm.org/D62627 ___ c

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

2020-03-23 Thread Zhizhou Yang via Phabricator via cfe-commits
zhizhouy updated this revision to Diff 252143. zhizhouy marked 4 inline comments as done. zhizhouy retitled this revision from "[NFC] Do not run CGProfilePass when -fno-integrated-as is on" to "[NFC] Do not run CGProfilePass when not using integrated assembler". zhizhouy added a comment. Thanks

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

2020-03-23 Thread Rong Xu via Phabricator via cfe-commits
xur added a comment. look good to me with the fix of comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:110 + /// Tuning option to enable/disable call graph profile. Its default value is + /// true. + bool CallGrpahProfile; The default value is spe