[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-30 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362185: [CMake] Provide an option to use relative paths in debug info (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62622?vs=202310&id=202351#toc Repository:

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-30 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D62622#1523269 , @aprantl wrote: > I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 __

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-30 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 202310. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-30 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about `L

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-29 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false impression. Is there a name that emphasizes that this affects the debug info of the built compiler? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D626

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 202064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

2019-05-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, aprantl, mgorny. Herald added projects: clang, LLVM. CMake always uses absolute file paths in the generated compiler invocation which results in absolute file paths being embe