ilya-biryukov added inline comments.
Comment at: clang/lib/Index/IndexSymbol.cpp:99
+ if (auto *VT = dyn_cast(D)) {
+Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic;
kadircet wrote:
> ilya-biryukov wrote:
> > kadircet wrote:
> > > what about
This revision was automatically updated to reflect the committed changes.
Closed by commit rC361996: [Index] Compute correct symbol kind for variable
templates (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62579?vs=201980&id=201981#toc
Repository:
ilya-biryukov updated this revision to Diff 201980.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Add a test for static variable template member
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62579/new/
https://rev
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Index/IndexSymbol.cpp:99
+ if (auto *VT = dyn_cast(D)) {
+Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic;
---
ilya-biryukov added inline comments.
Comment at: clang/lib/Index/IndexSymbol.cpp:99
+ if (auto *VT = dyn_cast(D)) {
+Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic;
kadircet wrote:
> what about function and class templates? Are they handled
kadircet added inline comments.
Comment at: clang/lib/Index/IndexSymbol.cpp:99
+ if (auto *VT = dyn_cast(D)) {
+Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic;
what about function and class templates? Are they handled in somewhere else?
Re
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: kadircet.
Herald added subscribers: arphaman, jkorous.
Herald added a project: clang.
The index library itself seems to never pass variable templates as
input, however clangd does.
Repository:
rG LLVM Github Monorepo
https:/
